tap: cask font sharding fix

[bevanjkay]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew typecheck with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

This is not the correct solution, but keeping open for visibility for now.
We need to instead detect if the Cask is a "font cask" based on the artifacts it includes. The same as here - 836d819

Before:

==> font-abel: latest
...
From: https://github.com/Homebrew/homebrew-cask/blob/HEAD/Casks/f/font-abel.rb

After:

brew info font-abel
==> font-abel: latest
...
From: https://github.com/Homebrew/homebrew-cask/blob/HEAD/Casks/font/font-a/font-abel.rb

[Bo98]

Is this accurate for apps like font-finagler?

[carlocab]

It seems simpler to me to move the token.start_with? logic into new_cask_path instead of adjusting the callers in various places.

[bevanjkay]

The whole thing is not quite right at the moment, as mentioned by Bo.

This is not the correct solution, but keeping open for visibility for now.
We need to instead detect if the Cask is a "font cask" based on the artifacts it includes. The same as here - 836d819

[MikeMcQuaid]

Is this accurate for apps like font-finagler?

Apps like this, if they haven't already been, should be renamed.

[MikeMcQuaid]

We need to instead detect if the Cask is a "font cask" based on the artifacts it includes. The same as here - 836d819

I can't see how that can be done at brew create time. This seems like the correct fix for that and brew audit should capture the cases where a font artefact is not installed.

[bevanjkay]

I have pushed the change, it will fail the type check because there is a public version of new_cask_path and a private version, but only a private version of new_cask_font_path. Should we combine the logic into the private new_cask_path method instead?

[miccal]

Is this accurate for apps like font-finagler?

Apps like this, if they haven't already been, should be renamed.

The naming follows our (strict) token reference, so I do not think they should be renamed.

[bevanjkay]

Superseded by #17311

[MikeMcQuaid]

The naming follows our (strict) token reference, so I do not think they should be renamed.

We should rename these and change this reference.